Skip to content

Conversation

@andygrove
Copy link
Member

This reverts commit 46bde0b.

Which issue does this PR close?

We pulled the trigger too soon on this and it looks like we need to go through IP clearance process, so reverting this for now.

@andygrove andygrove requested a review from jorgecarleitao May 4, 2021 14:15
@andygrove andygrove mentioned this pull request May 4, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #257 (25a87d6) into master (46bde0b) will increase coverage by 0.66%.
The diff coverage is n/a.

❗ Current head 25a87d6 differs from pull request most recent head 543639f. Consider uploading reports for the commit 543639f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   76.14%   76.80%   +0.66%     
==========================================
  Files         140      133       -7     
  Lines       23487    23284     -203     
==========================================
  Hits        17884    17884              
+ Misses       5603     5400     -203     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46bde0b...543639f. Read the comment docs.

Copy link
Contributor

@nevi-me nevi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably safe not to keep this open for too long

@nevi-me nevi-me merged commit d0af907 into apache:master May 4, 2021
andygrove referenced this pull request in andygrove/datafusion May 5, 2021
andygrove added a commit that referenced this pull request May 5, 2021
@houqp houqp added the python label Jul 29, 2021
@andygrove andygrove deleted the revert-python branch February 6, 2022 17:42
unkloud pushed a commit to unkloud/datafusion that referenced this pull request Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants