Move SQL Query Planner into new datafusion-sql crate
#2588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
commented
May 22, 2022
| quick_test(sql, expected); | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_offset_after_limit_with_limit_push() { |
Member
Author
There was a problem hiding this comment.
We shouldn't be testing optimizer rules here, just the SQL query planner
andygrove
changed the title
datafusion-sql cratedatafusion-sql crate
github-actions
bot
added
the
development-process
andygrove
commented
May 22, 2022
| https://crates.io/crates/datafusion-physical-expr/8.0.0 | ||
| https://crates.io/crates/datafusion-proto/8.0.0 | ||
| https://crates.io/crates/datafusion-data-access/8.0.0 | ||
| https://crates.io/crates/ballista/0.7.0 |
Member
Author
There was a problem hiding this comment.
removing ballista here is not related to this PR but was missed earlier
Contributor
|
I didn't review the code of this PR but I like where it is heading -- thank you @andygrove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2345
Rationale for this change
I would like the ability to have projects just depend on datafusion-sql if they are using DataFusion as a SQL parser + query planner and are not using it for execution.
What changes are included in this PR?
Here is the new crate dependency diagram:
Are there any user-facing changes?
Yes, API change and new crate.