Skip to content

Minor: Clean up array test #3121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
Aug 15, 2022
Merged

Minor: Clean up array test #3121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions datafusion/core/tests/sql/functions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ async fn query_concat() -> Result<()> {
Ok(())
}

// Revisit after implementing https://github.com/apache/arrow-rs/issues/925
#[tokio::test]
async fn query_array() -> Result<()> {
let schema = Arc::new(Schema::new(vec![
Expand All @@ -132,14 +131,18 @@ async fn query_array() -> Result<()> {
let ctx = SessionContext::new();
ctx.register_table("test", Arc::new(table))?;
let sql = "SELECT array(c1, cast(c2 as varchar)) FROM test";
let actual = execute(&ctx, sql).await;
let actual = execute_to_batches(&ctx, sql).await;
let expected = vec![
vec!["[,0]"],
vec!["[a,1]"],
vec!["[aa,NULL]"],
vec!["[aaa,3]"],
"+--------------------------------------+",
"| array(test.c1,CAST(test.c2 AS Utf8)) |",
"+--------------------------------------+",
"| [, 0] |",
"| [a, 1] |",
"| [aa, ] |",
"| [aaa, 3] |",
"+--------------------------------------+",
];
assert_eq!(expected, actual);
assert_batches_eq!(expected, &actual);
Ok(())
}

Expand All @@ -148,9 +151,15 @@ async fn query_array_scalar() -> Result<()> {
let ctx = SessionContext::new();

let sql = "SELECT array(1, 2, 3);";
let actual = execute(&ctx, sql).await;
let expected = vec![vec!["[1, 2, 3]"]];
assert_eq!(expected, actual);
let actual = execute_to_batches(&ctx, sql).await;
let expected = vec![
"+-----------------------------------+",
"| array(Int64(1),Int64(2),Int64(3)) |",
"+-----------------------------------+",
"| [1, 2, 3] |",
"+-----------------------------------+",
];
assert_batches_eq!(expected, &actual);
Ok(())
}

Expand Down