-
Notifications
You must be signed in to change notification settings - Fork 1.9k
add a readme for clickbench intro #3186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,52 @@ | ||||||
| <!--- | ||||||
| Licensed to the Apache Software Foundation (ASF) under one | ||||||
| or more contributor license agreements. See the NOTICE file | ||||||
| distributed with this work for additional information | ||||||
| regarding copyright ownership. The ASF licenses this file | ||||||
| to you under the Apache License, Version 2.0 (the | ||||||
| "License"); you may not use this file except in compliance | ||||||
| with the License. You may obtain a copy of the License at | ||||||
|
|
||||||
| http://www.apache.org/licenses/LICENSE-2.0 | ||||||
|
|
||||||
| Unless required by applicable law or agreed to in writing, | ||||||
| software distributed under the License is distributed on an | ||||||
| "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||||||
| KIND, either express or implied. See the License for the | ||||||
| specific language governing permissions and limitations | ||||||
| under the License. | ||||||
| --> | ||||||
|
|
||||||
| # Clickbench Benchmark | ||||||
|
|
||||||
| ## Introduction | ||||||
|
|
||||||
| <https://benchmark.clickhouse.com/> is a new benchmark set provided by ClickHouse. The current result for DataFusion is from Azure's `v16s_v2` VM | ||||||
|
|
||||||
|
|
||||||
| ## The way to reproduce | ||||||
|
|
||||||
| 1. `git clone git@github.com:ClickHouse/ClickBench.git` | ||||||
| 2. cd ClickBench | ||||||
| 3. `bash run.sh` | ||||||
|
|
||||||
| Note that this will output the needed result like the `result` field in <https://github.com/ClickHouse/ClickBench/blob/main/datafusion/results/f16s_v2.json>. We need to manually provide `system`, `date`, ... for now, and save a new json into `results` folder. After merged by ClickBench and new html files regenerated, it'll be shown in <https://benchmark.clickhouse.com/> . | ||||||
|
|
||||||
| There're 43 queries to compute, each will be executed 3 times. each rows contains the execution time for these 3 quries. The overall output will be a 43 by 3 matrix. | ||||||
|
|
||||||
| ## To generate human readable results | ||||||
|
|
||||||
| your can do | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| ```bash | ||||||
| bash run2.sh | ||||||
| ``` | ||||||
|
|
||||||
| Each query will be only exeute only once, for each query it'll print the SQL expression first then output the result. (Note that this index begins with 1, the ClickBench begins with 0) | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| ## Known Issues | ||||||
|
|
||||||
|
|
||||||
| 1. importing parquet by `datafusion-cli` make column name case-sensitive (i.e. i need to query thoses column by double quoted string). The original `queries.sql`'s column name <https://github.com/ClickHouse/ClickBench/blob/main/clickhouse/queries.sql> contains no double quotes, I manually added the double quotes for all the column name for now <https://github.com/ClickHouse/ClickBench/blob/main/datafusion/queries.sql> | ||||||
|
|
||||||
| 2. since our parquet importer doesn't support schema, I use some functions to convert the data type in queries (i.e. "EventDate" becomes "EventDate::INT::DATE"). Note that other plaform support this, so it could be added while creating table i.e. <https://github.com/ClickHouse/ClickBench/blob/main/clickhouse/create.sql> | ||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should move this file to
benchmarks/clickbench/README.mdso that all the benchmarks are in one place.