You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of TPCH Query 15, a LogicalPlan is created for the first part of the query (creating the view), but a LogicalPlan for the second part of the query cannot be constructed before executing the first LogicalPlan. This is because the view cannot be found in the session context until its LogicalPlan is executed.
What changes are included in this PR?
Update tpch.rs to generate a LogicalPlan, and then immediately execute it before generating the next LogicalPlan for both tpch.rs::benchmark_datafusion and tpch.rs::run_query
- tpch.rs::benchmark_datafusion now executes LogicalPlan immediately after building
- tpch.rs::run_query now executes LogicalPlan immediately after building
Resolves #3273
@andygrove@mingmwang Would one of you mind giving this a quick look? If we want to keep the output defined in the execute_query method, I could also rewrite the logic defined in create_logical_plans to create plans one at a time. Otherwise, I
believe the create_logical_plans method and execute_query methods can both be removed.
- Updated execute_query to accept sql string instead of LogicalPlan as second argument
- Updated tpch.rs::run_query to use tpch.rs::execute_query
- Updated tpch.rs::benchmark_datafusion to use tpch.rs::execute_query
Benchmark runs are scheduled for baseline = 7aed4d6 and contender = 3effee8. 3effee8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3273
Which issue does this PR close?
Closes #3273
Rationale for this change
In the case of TPCH Query 15, a LogicalPlan is created for the first part of the query (creating the view), but a LogicalPlan for the second part of the query cannot be constructed before executing the first LogicalPlan. This is because the view cannot be found in the session context until its LogicalPlan is executed.
What changes are included in this PR?
Update tpch.rs to generate a LogicalPlan, and then immediately execute it before generating the next LogicalPlan for both
tpch.rs::benchmark_datafusionandtpch.rs::run_queryAre there any user-facing changes?
No.