Skip to content

Fix the test failure of size_of_scalar failure on M1/M2 Mac #3398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andygrove merged 3 commits into from
Sep 12, 2022
Merged

Fix the test failure of size_of_scalar failure on M1/M2 Mac #3398

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4424d8
fix
HaoYang670 Sep 8, 2022
8fdbb51
Merge branch 'master' into 3383_size_of_scalar
HaoYang670 Sep 12, 2022
4090903
always 48
HaoYang670 Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions datafusion/common/src/scalar.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2575,12 +2575,7 @@ mod tests {
// The alignment requirements differ across architectures and
// thus the size of the enum appears to as as well

let expected = match cfg!(target_arch = "aarch64") {
true => 64,
false => 48,
};

assert_eq!(std::mem::size_of::<ScalarValue>(), expected);
assert_eq!(std::mem::size_of::<ScalarValue>(), 48);
Copy link
Contributor

@alamb alamb Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fascinating -- perhaps rust has improved it support for aarch64

}

#[test]
Expand Down