Skip to content

Actually test that ScalarValues are the same after round trip serialization #3537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andygrove merged 1 commit into from
Sep 20, 2022
Merged

Actually test that ScalarValues are the same after round trip serialization #3537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions datafusion/proto/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,17 @@ mod roundtrip_tests {
let proto: super::protobuf::ScalarValue = (&test_case)
.try_into()
.expect("failed conversion to protobuf");
let _roundtrip: ScalarValue =
(&proto).try_into().expect("failed conversion to protobuf");

let roundtrip: ScalarValue = (&proto)
.try_into()
.expect("failed conversion from protobuf");

assert_eq!(
test_case, roundtrip,
"ScalarValue was not the same after round trip!\n\n\
Input: {:?}\n\nRoundtrip: {:?}",
test_case, roundtrip
);
}
}

Expand Down