Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Sep 21, 2022

Which issue does this PR close?

Fixes a build problem introduce in ff718d0 (a module was removed but there was still a reference to it)

Rationale for this change

CI is failing on master

What changes are included in this PR?

Remove pub mod declaration for removed module

Are there any user-facing changes?

No

@alamb alamb marked this pull request as ready for review September 21, 2022 17:55
@alamb
Copy link
Contributor Author

alamb commented Sep 21, 2022

I plan to merge this as soon as all the tests pass for me locally so we can fix master

@alamb alamb merged commit 634d912 into apache:master Sep 21, 2022
@Dandandan
Copy link
Contributor

Oops, thanks @alamb !

@alamb alamb deleted the alamb/fix_builds branch September 21, 2022 17:59
@ursabot
Copy link

ursabot commented Sep 21, 2022

Benchmark runs are scheduled for baseline = 31acc83 and contender = 634d912. 634d912 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@github-actions github-actions bot added the core Core DataFusion crate label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants