-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add Pull Request guidelines to contributor guide #3985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
avantgardnerio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could potentially add wording about it specifically being "days" not "business days" or >=1 approval, but LGTM.
|
Thanks everyone! |
I wanted to keep it simple to begin with -- let's try this wording and then refine with additional details if necessary. |
|
Benchmark runs are scheduled for baseline = 8f1ae58 and contender = 22dea55. 22dea55 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
* Add Pull Request guidelines to contributor guide * prettier
Which issue does this PR close?
Closes #3957
Rationale for this change
Document how we should handle PRs
What changes are included in this PR?
Add Pull Request guidelines to contributor guide
Are there any user-facing changes?
docs