Update sqlparser requirement from 0.26 to 0.27 #4226

alamb · 2022-11-15T20:12:40Z

Which issue does this PR close?

Closes #4201

Rationale for this change

Keep up with dependencies

What changes are included in this PR?

Take @dependabot changes in #4201 and fix up the code for the changes

Update sqlparser requirement from 0.26 to 0.27

Changelog

Sourced from sqlparser's changelog.

[0.27.0] 2022-11-11

Added

Support ON CONFLICT and RETURNING in UPDATE statement (#666) - Thanks @main and @gamife

Support FULLTEXT option on create table for MySQL and Generic dialects (#702) - Thanks @AugustoFKL

Support ARRAY_AGG for Bigquery and Snowflake (#662) - Thanks @SuperBo

Support DISTINCT for SetOperator (#689) - Thanks @unvalley

Support the ARRAY type of Snowflake (#699) - Thanks @yuval-illumex

Support create sequence with options INCREMENT, MINVALUE, MAXVALUE, START etc. (#681) - Thanks @sam-mmm

Support : operator for semi-structured data in Snowflake(#693) - Thanks @yuval-illumex

Support ALTER TABLE DROP PRIMARY KEY (#682) - Thanks @ding-young

Support NUMERIC and DEC ANSI data types (#695) - Thanks @AugustoFKL

Support modifiers for Custom Datatype (#680) - Thanks @sunng87

Changed

Add precision for TIME, DATETIME, and TIMESTAMP data types (#701) - Thanks @AugustoFKL

add Date keyword (#691) - Thanks @sarahyurick

Update simple_logger requirement from 2.1 to 4.0 - Thanks @dependabot

Fixed

Fix broken DataFusion link (#703) - Thanks @jmg-duarte

Add MySql, BigQuery to all dialects tests, fixed bugs (#697) - Thanks @omer-shtivi

[0.26.0] 2022-10-19

Added

Support MySQL table option {INDEX | KEY} in CREATE TABLE definiton (#665) - Thanks @AugustoFKL

Support CREATE [ { TEMPORARY | TEMP } ] SEQUENCE [ IF NOT EXISTS ] <sequence_name> (#678) - Thanks @sam-mmm

Support DROP SEQUENCE statement (#673) - Thanks @sam-mmm

Support for ANSI types CHARACTER LARGE OBJECT[(p)] and CHAR LARGE OBJECT[(p)] (#671) - Thanks @AugustoFKL

Support [CACHE|UNCACHE] TABLE (#670) - Thanks @francis-du

Support CEIL(expr TO DateTimeField) and FLOOR(expr TO DateTimeField) - Thanks @sarahyurick

Support all ansii character string types, (#648) - Thanks @AugustoFKL

Changed

Support expressions inside window frames (#655) - Thanks @mustafasrepo and @ozankabak

Support unit on char length units for small character strings (#663) - Thanks @AugustoFKL

Replace booleans on SET ROLE with a single enum. (#664) - Thanks @AugustoFKL

Replace Options with enum for DECIMAL precision (#654) - Thanks @AugustoFKL

[0.25.0] 2022-10-03

Added

Support AUTHORIZATION clause in CREATE SCHEMA statements (#641) - Thanks @AugustoFKL

Support optional precision for CLOB and BLOB (#639) - Thanks @AugustoFKL

Support optional precision in VARBINARY and BINARY (#637) - Thanks @AugustoFKL

... (truncated)

Commits

0d91662 (cargo-release) version 0.27.0
6a84710 Update CHANGELOG for 0.27.0 release (#706)
814367a Implement ON CONFLICT and RETURNING (#666)
ae1c690 Fix broken DataFusion link (#703)
65c5a37 feat: add precision for TIME, DATETIME, and TIMESTAMP data types (#701)
cdf4447 feat: add FULLTEXT option on create table for MySQL and Generic dialects (#702)
87b4a16 Parse ARRAY_AGG for Bigquery and Snowflake (#662)
0428ac7 Add MySql, BigQuery to all dialects (#697)
f7817bc Support DISTINCT for SetOperator (#689)
0f7e144 Support the ARRAY type of Snowflake (#699)
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Updates the requirements on [sqlparser](https://github.com/sqlparser-rs/sqlparser-rs) to permit the latest version. - [Release notes](https://github.com/sqlparser-rs/sqlparser-rs/releases) - [Changelog](https://github.com/sqlparser-rs/sqlparser-rs/blob/main/CHANGELOG.md) - [Commits](apache/datafusion-sqlparser-rs@v0.26.0...v0.27.0) --- updated-dependencies: - dependency-name: sqlparser dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

…ster/sqlparser-0.27

…rser

alamb · 2022-11-15T22:31:20Z

This PR is not quite ready -- I need to fix up changes related to apache/datafusion-sqlparser-rs#662 -- but ran out of time todya

…rser

alamb · 2022-11-17T01:53:32Z

datafusion/core/tests/sql/aggregates.rs

+
+    let results = plan_and_collect(
+        &ctx,
+        "SELECT array_agg(c13 ORDER BY c1) FROM aggregate_test_100",


this is newly added syntax support in apache/datafusion-sqlparser-rs#662

alamb · 2022-11-17T01:53:40Z

datafusion/sql/src/planner.rs

+            within_group,
+        } = array_agg;
+
+        if let Some(order_by) = order_by {


due to apache/datafusion-sqlparser-rs#662

alamb · 2022-11-17T11:31:15Z

datafusion/sql/src/planner.rs

-                all,
+                set_quantifier,
            } => {
+                let all = match set_quantifier {


sqlparser now distinguishes between ALL , DISTINCT and not specified (previously, not specified left all=false)

ursabot · 2022-11-17T15:21:51Z

Benchmark runs are scheduled for baseline = 929a175 and contender = a0581dc. a0581dc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

dependabot bot and others added 3 commits November 14, 2022 08:11

Merge remote-tracking branch 'apache/master' into dependabot/cargo/ma…

3055368

…ster/sqlparser-0.27

Update to sqlparser 0.27

532a38e

alamb mentioned this pull request Nov 15, 2022

Update sqlparser requirement from 0.26 to 0.27 #4201

Closed

github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner labels Nov 15, 2022

Update datafusion-cli lock

c4db235

andygrove approved these changes Nov 15, 2022

View reviewed changes

alamb added 2 commits November 15, 2022 17:05

Merge remote-tracking branch 'apache/master' into alamb/update_sql_pa…

e280570

…rser

fix up some tests

94aa98d

alamb marked this pull request as draft November 15, 2022 22:30

alamb mentioned this pull request Nov 16, 2022

Minor: remove unecessary clone() in planner #4249

Merged

alamb added 4 commits November 16, 2022 20:43

re-implement handling for array_agg

f39a05f

add test

5aee290

Merge remote-tracking branch 'apache/master' into alamb/update_sql_pa…

078002e

…rser

Merge remote-tracking branch 'apache/master' into alamb/update_sql_pa…

d2f97bc

…rser

alamb commented Nov 17, 2022

View reviewed changes

alamb marked this pull request as ready for review November 17, 2022 14:21

andygrove approved these changes Nov 17, 2022

View reviewed changes

alamb merged commit a0581dc into apache:master Nov 17, 2022

alamb deleted the alamb/update_sql_parser branch November 17, 2022 15:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update sqlparser requirement from 0.26 to 0.27 #4226

Update sqlparser requirement from 0.26 to 0.27 #4226

Uh oh!

alamb commented Nov 15, 2022

Uh oh!

alamb commented Nov 15, 2022

Uh oh!

alamb Nov 17, 2022

Uh oh!

alamb Nov 17, 2022

Uh oh!

alamb Nov 17, 2022

Uh oh!

ursabot commented Nov 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Update sqlparser requirement from 0.26 to 0.27 #4226

Update sqlparser requirement from 0.26 to 0.27 #4226

Uh oh!

Conversation

alamb commented Nov 15, 2022

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

[0.27.0] 2022-11-11

Added

Changed

Fixed

[0.26.0] 2022-10-19

Added

Changed

[0.25.0] 2022-10-03

Added

Uh oh!

alamb commented Nov 15, 2022

Uh oh!

alamb Nov 17, 2022

Choose a reason for hiding this comment

Uh oh!

alamb Nov 17, 2022

Choose a reason for hiding this comment

Uh oh!

alamb Nov 17, 2022

Choose a reason for hiding this comment

Uh oh!

ursabot commented Nov 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants