Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Nov 16, 2022

Which issue does this PR close?

None

Rationale for this change

There is a logical conflict in #4192 and #4212 (both from @jackwener it turns out 😆 )

Without this fix master branch is broken: https://github.com/apache/arrow-datafusion/actions/runs/3483339533/jobs/5826711615

error[E0609]: no field `alias` on type `&datafusion_expr::Union`
   --> datafusion/optimizer/src/propagate_empty_relation.rs:123:35
    |
123 | ...                   union.alias.clone(),
    |                             ^^^^^ unknown field
    |
    = note: available fields are: `inputs`, `schema`

error[E0560]: struct `datafusion_expr::Union` has no field named `alias`
   --> datafusion/optimizer/src/propagate_empty_relation.rs:130:25
    |
130 |                         alias: union.alias.clone(),
    |                         ^^^^^ `datafusion_expr::Union` does not have this field
    |
    = note: available fields are: `inputs`, `schema`

error[E0609]: no field `alias` on type `&datafusion_expr::Union`
   --> datafusion/optimizer/src/propagate_empty_relation.rs:130:38
    |
130 |                         alias: union.alias.clone(),
    |                                      ^^^^^ unknown field
    |
    = note: available fields are: `inputs`, `schema`

What changes are included in this PR?

remove unused union alias

Are these changes tested?

Yes existing tests

Are there any user-facing changes?

@github-actions github-actions bot added the optimizer Optimizer rules label Nov 16, 2022
@jackwener
Copy link
Member

😂 classic bors problem

@jackwener
Copy link
Member

looks like ut exist problem, I also find some legacy code. I can clear and fix them.

@alamb
Copy link
Contributor Author

alamb commented Nov 17, 2022

Superceded by #4252

@jackwener jackwener mentioned this pull request Nov 17, 2022
@alamb alamb deleted the alamb/fix_build_again branch August 8, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

optimizer Optimizer rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants