-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix bugs in parsing with header row and partitioned by
#4268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: remzi <13716567376yh@gmail.com>
|
For fn parse_has_file_compression_type(&mut self) -> Result<bool, ParserError> {
// return error if finding `compression` but not find `TYPE`
} |
datafusion/sql/src/parser.rs
Outdated
| let sql = "CREATE EXTERNAL TABLE t STORED AS CSV WITH HEADER LOCATION 'abc'"; | ||
| expect_parse_error(sql, "sql parser error: Expected LOCATION, found: WITH"); | ||
|
|
||
| // Error case: `with header` is an invalid syntax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: comment seems incorrect here
Signed-off-by: remzi <13716567376yh@gmail.com>
with header row and partitioned by
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @HaoYang670
|
CI failure due to #4294 (not this PR) |
|
Benchmark runs are scheduled for baseline = 60d9bbe and contender = 0bb5d4d. 0bb5d4d is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Signed-off-by: remzi 13716567376yh@gmail.com
Which issue does this PR close?
Part of #4262.
Rationale for this change
What changes are included in this PR?
Fix the errors in parsing
with header rowandpartitioned by.Are these changes tested?
Are there any user-facing changes?