Skip to content

Conversation

@retikulum
Copy link
Contributor

Which issue does this PR close?

Discussed in #3152 .

Rationale for this change

This is the new PR in series to improve error handling for downcasting.

What changes are included in this PR?

  • Add as_xxx_array functions for following types to downcast:
    • MapArray
    • NullArray
    • UnionArray
    • TimestampNanosecondArray
    • TimestampMillisecondArray
    • TimestampMicrosecondArray
    • TimestampSecondArray
    • BinaryArray

@github-actions github-actions bot added core Core DataFusion crate physical-expr Changes to the physical-expr crates labels Nov 30, 2022
@retikulum
Copy link
Contributor Author

Is there any problem about cargo test pyarrow check? Other newly opened PRs are also failed on this test. It seems that problem is in the installation part.

image

@alamb
Copy link
Contributor

alamb commented Nov 30, 2022

Is there any problem about cargo test pyarrow check? Other newly opened PRs are also failed on this test. It seems that problem is in the installation part.

I agree there is some problem (maybe @isidentical has some idea). I haven't had a chance to look at the check recently and I am nearing my end of day here. If no one has figured it out tomorrow I'll look into it

@alamb
Copy link
Contributor

alamb commented Dec 1, 2022

Check got fixed in #4450

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me -- thank you @retikulum

@alamb alamb merged commit 799dd74 into apache:master Dec 1, 2022
@ursabot
Copy link

ursabot commented Dec 1, 2022

Benchmark runs are scheduled for baseline = 0253459 and contender = 799dd74. 799dd74 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@retikulum retikulum deleted the 3152_improve_error_handling branch December 3, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate physical-expr Changes to the physical-expr crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants