Skip to content

Conversation

@xudong963
Copy link
Member

Which issue does this PR close?

Follow up: #4496

Rationale for this change

What changes are included in this PR?

Refactor some code by review suggestions

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label Dec 4, 2022
@xudong963 xudong963 changed the title Follow insert Refactor code in insert for sqllogictest Dec 4, 2022
return Err(DFSqlLogicTestError::NotImplemented(
"Only support insert values".to_string(),
));
// Directly panic: make it easy to find the location of the error.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked in my local, and it works

[insert.slt] Running query: "insert into users select * from users;"
thread 'main' panicked at 'explicit panic', datafusion/core/tests/sqllogictests/src/insert/mod.rs:48:21
stack backtrace:
   0: rust_begin_unwind
             at /rustc/96ddd32c4bfb1d78f0cd03eb068b1710a8cebeef/library/std/src/panicking.rs:575:5
   1: core::panicking::panic_fmt
             at /rustc/96ddd32c4bfb1d78f0cd03eb068b1710a8cebeef/library/core/src/panicking.rs:65:14
   2: core::panicking::panic
             at /rustc/96ddd32c4bfb1d78f0cd03eb068b1710a8cebeef/library/core/src/panicking.rs:114:5
   3: sqllogictests::insert::insert::{{closure}}
             at ./tests/sqllogictests/src/insert/mod.rs:48:21
   4: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
             at /rustc/96ddd32c4bfb1d78f0cd03eb068b1710a8cebeef/library/core/src/future/mod.rs:91:19
   5: sqllogictests::run_query::{{closure}}
             at ./tests/sqllogictests/src/main.rs:151:53
   6: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
             at /rustc/96ddd32c4bfb1d78f0cd03eb068b1710a8cebeef/library/core/src/future/mod.rs:91:19
   7: <sqllogictests::DataFusion as sqllogictest::runner::AsyncDB>::run::{{closure}}
             at ./tests/sqllogictests/src/main.rs:48:47

@xudong963 xudong963 added the sqllogictest SQL Logic Tests (.slt) label Dec 4, 2022
@xudong963 xudong963 requested a review from alamb December 4, 2022 14:28
@xudong963 xudong963 changed the title Refactor code in insert for sqllogictest Refactor code for insert in sqllogictest Dec 4, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb
Copy link
Contributor

alamb commented Dec 4, 2022

Thanks @xudong963

@xudong963 xudong963 merged commit 4f7b003 into apache:master Dec 4, 2022
@xudong963 xudong963 deleted the follow_insert branch December 4, 2022 17:46
@ursabot
Copy link

ursabot commented Dec 4, 2022

Benchmark runs are scheduled for baseline = e056a5c and contender = 4f7b003. 4f7b003 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants