refactor code about query -> plan for subqueries
#4559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackwener
commented
Dec 8, 2022
Comment on lines
-455
to
-460
| let logical_plan = self.query_to_plan_with_alias( | ||
| *cte.query, | ||
| None, | ||
| &mut planner_context.clone(), | ||
| outer_query_schema, | ||
| )?; |
Member
Author
There was a problem hiding this comment.
just subquery -> plan need to pass outer_query_schema.
alamb
approved these changes
Dec 9, 2022
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Very nice change @jackwener
| query: Query, | ||
| alias: Option<String>, | ||
| planner_context: &mut PlannerContext, | ||
| outer_query_schema: Option<&DFSchema>, |
|
|
||
| /// Generate a logic plan from an SQL query with optional alias | ||
| pub fn query_to_plan_with_alias( | ||
| /// Generate a logic plan from an SQL query. |
Contributor
There was a problem hiding this comment.
This API makes a lot of sense -- thank you @jackwener
alamb
changed the title
query -> planquery -> plan for subqueries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
After #4484 #4141 , we remove the alias in
query_to_plan(), so we can remove it.What's more, we can find just
subquery_to_planneed to passouter_schema.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?