Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Dec 9, 2022

Which issue does this PR close?

N/a

Rationale for this change

#4432 had a logical conflict (and I didn't recheck it)

First master CI faillure: https://github.com/apache/arrow-datafusion/actions/runs/3657087583/jobs/6180276339


    Checking datafusion-benchmarks v15.0.0 (/__w/arrow-datafusion/arrow-datafusion/benchmarks)
error[E0599]: no function or associated item named `try_new` found for struct `CrossJoinExec` in the current scope
   --> datafusion/proto/src/physical_plan/mod.rs:560:44
    |
560 |                 Ok(Arc::new(CrossJoinExec::try_new(left, right)?))
    |                                            ^^^^^^^ function or associated item not found in `CrossJoinExec`

What changes are included in this PR?

Fix compilation of datafusion-proto

Are these changes tested?

yes

@alamb
Copy link
Contributor Author

alamb commented Dec 9, 2022

I plan to merge this PR as soon as the check CI has finished to unbreak master

@alamb
Copy link
Contributor Author

alamb commented Dec 9, 2022

@alamb alamb merged commit f2eb3b2 into apache:master Dec 9, 2022
@alamb alamb deleted the alamb/fix_build branch December 9, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant