Avoid boxing config keys #4762
Closed
Avoid boxing config keys #4762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Dec 28, 2022
| pub struct ConfigDefinition { | ||
| /// key used to identifier this configuration option | ||
| key: String, | ||
| key: Cow<'static, str>, |
Contributor
There was a problem hiding this comment.
What would you think about using Arc here instead?
Arc might would be more consistent with the rest of the DataFusion codebase as well as help systems like Ballista where the configuration was serialized / deserialized.
I believe with a Cow and without any extra work, the deserialized ConfigOptions will still be owned (and copied) Strings
Contributor
Author
There was a problem hiding this comment.
Hmm... You raise a good point r.e. serialization, perhaps we should just make ConfigOptions a struct... I'll leave this open if anyone else has any thoughts
Contributor
Author
|
Closing in favour of #4771 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Relates to #4517
Rationale for this change
Config keys are almost always static strings, currently we allocate a
Stringfor each of these, and clone these allocations when we cloneSessionConfig, which is done multiple times per query. Switching to useCow<'static, str>avoids this.I prevaricated about this change as we may eventually change
ConfigOptionsinto a struct, but thought I'd propose it anyway and see what people thoughtWhat changes are included in this PR?
This changes the definition of
ConfigOptionsto avoid boxing static strings.Are these changes tested?
Are there any user-facing changes?