-
Notifications
You must be signed in to change notification settings - Fork 1.9k
remove Operator::{Like,NotLike,ILike,NotILike} #4792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you 🙏 @unconsolable -- I plan to review this one carefully tomorrow |
664879d to
95a266c
Compare
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @unconsolable -- this is a very beautiful first PR 🏆
I had a few minor suggestions but overall this looks very close to mergable.
Thank you so much 🙏
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @unconsolable and @crepererum
|
🚀 |
|
Benchmark runs are scheduled for baseline = 24023b5 and contender = 702e117. 702e117 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #4765 .
Rationale for this change
See issue.
What changes are included in this PR?
Operator::{Like,NotLike,ILike,NotILike}datafusion_expr::expr::Expr::{like, not_like, ilike, not_ilike}, returnExpr::{Like, ILike}version.TypeCoercionRewriteruselike_coerciondirectly, bypassOperator::Likeetc.LikeExprindatafusion_physical_expr::expressions, bypassOperator::Likeetc. Also convertExpr::{like, not_like, ilike, not_ilike}to thisLikeExprPhysicalExprNodeproto, make corresponding change infrom_proto&to_protoAre these changes tested?
TypeCoercionRewriterandLikeExprare tested correspondingly.datafusion::physical_plan::planner::tests::errors(), tests forlike/ilike/not like/not ilikeare removed, as forExpr::LikeandExpr::ILike,coerce_typesare not performed inExpr::get_typehttps://github.com/apache/arrow-datafusion/blob/54ae4323a730a4a34c6b5f638e2083f0c3fe5dcc/datafusion/expr/src/expr_schema.rs#L128-L130
Are there any user-facing changes?
No.