Skip to content

Conversation

@snmvaughan
Copy link

Which issue does this PR close?

Closes #5222.

Currently a work in progress that handles the scalar case.

What changes are included in this PR?

Replaces a simple check for equality with a coercion based check. Replaces DataType::Utf8 only implementation with the Arrow dyn implementations.

Are these changes tested?

Existing tests pass. I'll supplement the tests with additional types.

Are there any user-facing changes?

No

…e to support Dictionary and LargeStringArray
@github-actions github-actions bot added the physical-expr Changes to the physical-expr crates label Feb 9, 2023
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snmvaughan would be great to have a test showing like* now supports Dictionary and LargeStringArray

@snmvaughan snmvaughan marked this pull request as draft February 9, 2023 17:32
@snmvaughan
Copy link
Author

@comphead Those were the additional tests I planned to add today.

@alamb
Copy link
Contributor

alamb commented Mar 4, 2023

FWIW I am hoping the arrow_cast function (from #5166) makes it easier to write such tests (as we can we can do it with (only0 SQL)

@alamb
Copy link
Contributor

alamb commented Mar 19, 2023

@alamb
Copy link
Contributor

alamb commented Apr 8, 2024

Since this has been open for more than a year, closing it down. Feel free to reopen if/when you keep working on it.

@alamb alamb closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-expr Changes to the physical-expr crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use _dyn and _scalar_dyn for operations like, ilike, nlike, and nilike to support Dictionary and LargeStringArray

3 participants