Skip to content

Conversation

@jackwener
Copy link
Member

Which issue does this PR close?

Closes #5233.
Part of #4685

Rationale for this change

What changes are included in this PR?

Are these changes tested?

No need, current tests can cover this problem, but it was hidden by skip_failed_rules.

set pub skip_failed_rules: bool, default = false

Before this PR, sort_on_window_null_string will fail.
After this PR, they will success.

Are there any user-facing changes?

@github-actions github-actions bot added logical-expr Logical plan and expressions optimizer Optimizer rules labels Feb 10, 2023
@jackwener jackwener force-pushed the fix_sort_on_window_null_string branch from 5bdedc3 to 067b1b1 Compare February 10, 2023 05:50
@jackwener
Copy link
Member Author

cc @HaoYang670 @liukun4515 @alamb

@mustafasrepo
Copy link
Contributor

LGTM!. Thanks

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I think it would be neat to have some sort of test coverage in the sense that if this code was removed, all the tests still pass. So the bug could get reintroduced and we would not catch the regression

For example, perhaps we could set https://docs.rs/datafusion/17.0.0/datafusion/config/struct.OptimizerOptions.html#structfield.skip_failed_rules to false for a test that was failing in this way 🤔

@alamb alamb merged commit f2ce2b9 into apache:master Feb 10, 2023
@ursabot
Copy link

ursabot commented Feb 10, 2023

Benchmark runs are scheduled for baseline = 0a5e8ae and contender = f2ce2b9. f2ce2b9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@jackwener jackwener deleted the fix_sort_on_window_null_string branch February 11, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

logical-expr Logical plan and expressions optimizer Optimizer rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test sort_on_window_null_string failed after disable skip_fail.

4 participants