[sqllogictest] Define output types and check them in tests

[melgenek]

Which issue does this PR close?

Closes #4499.

Rationale for this change

Currently, the type strings in sqllogictests are ignored, and letters have no meaning to them. Also, some tests benefit, like null checks, benefit from type checking.

What changes are included in this PR?

• this pr defines a custom DFColumnType that has more types than the original sqllite set of types
• updates tests to use these custom types
• forces the sqllogictestrunner to check the types

Are these changes tested?

Github actions.

Are there any user-facing changes?

No

[alamb]

Thank you so much @melgenek this is looking great. This feature is so cool!

Prior to merging this PR, I would like to suggest:

1. Update the type characters to be more inline with other systems
2. Wait for a release of sqllogictests-rs that includes the complete feature (as I think it is critical to the maintenance of the sqllogictests in datafusion)

cc @xudong963

[xudong963]

Cool, I'm traveling. Will review it as soon as possible.

[melgenek]

Wait for a release of sqllogictests-rs that includes the complete feature (as I think it is critical to the maintenance of the sqllogictests in datafusion)

👍

[alamb]

LGTM -- thanks @melgenek -- no we just need to wait on the sqllogictest release / upgrade and we'll be good to go

[alamb]

Marking as draft until the upstream release is ready

[melgenek]

@alamb I updated the sqllogictest-rs to 0.13.0. The --complete option fills in the types now.
In fact, you can now write query\n without specifying any types at all and completion would work.

This pr is good to go.

[alamb]

Thank you so much @melgenek

I merged this PR up to the latest main and ran cargo test --test sqllogictests -- --complete and there are no changes 👍

Then I also tried purposely updating test output to be incorrect, and I got an error as expected

Error: query columns mismatch:
[SQL] SELECT * from information_schema.tables;
[Expected] [R][R]
[Actual  ] [T][T][T][T]
at tests/sqllogictests/test_files/information_schema.slt:33

And then cargo test --test sqllogictests -- --complete fixed the problem I introduced

❤️ 🚀 -- thank you

[ursabot]

Benchmark runs are scheduled for baseline = f154a9a and contender = 22b974f. 22b974f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java