enhance the checking of type errors in the test window_frame_creation
#5257
Conversation
Signed-off-by: remzi <13716567376yh@gmail.com>
|
@jackwener @alamb could you please help to review? Thank you! |
jackwener
left a comment
jackwener
left a comment
There was a problem hiding this comment.
Look great to me. Thank you @HaoYang670.
This PR is same with #5224.
I prepare polish them like this PR.
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @HaoYang670 and @jackwener
I think @mustafasrepo and @metesynnada may be interested in these changes (to improve error checking / move the type checks out of physical plan creation and into logical plan creation)
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
|
LGTM!. This is a nice example to add tests for skipped errors. Thank you @HaoYang670. |
|
Benchmark runs are scheduled for baseline = 016ad8e and contender = 3da7902. 3da7902 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…n` (apache#5257) * enhance the test Signed-off-by: remzi <13716567376yh@gmail.com> * update comment Signed-off-by: remzi <13716567376yh@gmail.com> --------- Signed-off-by: remzi <13716567376yh@gmail.com>
5 participants
Signed-off-by: remzi 13716567376yh@gmail.com
Which issue does this PR close?
None.
Related to #4685.
Rationale for this change
We should test the type errors in a query could be detected from either the logical plan (skip_failed_rules = false) or the physical plan (skip_failed_rules = true).
What changes are included in this PR?
Only update the test.
Are these changes tested?
Are there any user-facing changes?