Skip to content

minor: port more window tests to sqllogictests #5330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alamb merged 5 commits into from
Feb 23, 2023
Merged

minor: port more window tests to sqllogictests #5330

alamb merged 5 commits into from
Feb 23, 2023

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Feb 18, 2023

Which issue does this PR close?

Part of #4495

Follow on to #5199

Rationale for this change

I am trying to keep the testability of DataFusion reasonable. Sqllogictests are easier to add / update so we are trying to move stuff over there.

What changes are included in this PR?

Port more window tests to window.slt

Are these changes tested?

Yes all tests

Are there any user-facing changes?

No

@alamb alamb added the development-process Related to development process of DataFusion label Feb 18, 2023
@alamb alamb changed the title minor: port more window tests minor: port more window tests to sqllogitsts Feb 18, 2023
@alamb alamb changed the title minor: port more window tests to sqllogitsts minor: port more window tests to sqllogictests Feb 18, 2023
alamb
alamb commented Feb 18, 2023
View reviewed changes
datafusion/core/tests/sqllogictests/test_files/window.slt Outdated
#// }

# async fn window_frame_ranges_preceding_following_desc() -> Result<()> {
query error DataFusion error: Internal error: Operator + is not implemented for types Int8(5) and Utf8("1"). This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker
Copy link
Contributor Author

@alamb alamb Feb 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is strange to me -- it seems like a real bug -- if you agree I will file a ticket for it.

However, the corresponding query ran just fine in .rs rust tests 🤔

Copy link
Contributor Author

@alamb alamb Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filed #5346

Copy link
Member

@jackwener jackwener Feb 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a bug, I also met it in other code when disable skip_failed

datafusion/expr/src/window_frame.rs
} else {
return Err(DataFusionError::Plan(format!(
"With window frame of type RANGE, the ORDER BY expression must be of length 1, got {}", order_bys)));
"With window frame of type RANGE, the ORDER BY expression must be of length 1, got {order_bys}")));
Copy link
Contributor Author

@alamb alamb Feb 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy was complaining about this for me locally

@alamb alamb marked this pull request as ready for review February 18, 2023 17:38
@alamb
Copy link
Contributor Author

alamb commented Feb 18, 2023

cc @mustafasrepo and @ozankabak

ozankabak
ozankabak approved these changes Feb 18, 2023
View reviewed changes
Copy link
Contributor

@ozankabak ozankabak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we will use the SLT functionality for new tests too from now on. Some CI checks are failing though due to an error message matching issue.

@alamb alamb mentioned this pull request Feb 20, 2023
Closed
@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions sqllogictest SQL Logic Tests (.slt) and removed development-process Related to development process of DataFusion labels Feb 20, 2023
jackwener
jackwener approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I prepare to merge this PR in one day in case of new conflict.

@alamb
Copy link
Contributor Author

alamb commented Feb 23, 2023

Thanks everyone!

@alamb alamb merged commit 3882eea into apache:main Feb 23, 2023
@ursabot
Copy link

ursabot commented Feb 23, 2023

Benchmark runs are scheduled for baseline = a79f9c8 and contender = 3882eea. 3882eea is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

jiangzhx pushed a commit to jiangzhx/arrow-datafusion that referenced this pull request Feb 24, 2023
@alamb @jiangzhx
minor: port more window tests to sqllogictests (apache#5330)
5b2583a 
* minor: port more window tests

* Update comments and add link to ticket

* escape
@alamb alamb mentioned this pull request Feb 28, 2023
Merged
@alamb alamb deleted the alamb/port_more-tests branch July 26, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackwener jackwener jackwener approved these changes

@ozankabak ozankabak ozankabak approved these changes

Assignees

No one assigned

Labels

core Core DataFusion crate logical-expr Logical plan and expressions sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alamb @ursabot @ozankabak @jackwener