Skip to content

minor: Port more window tests to sqlogictests #5434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 4 commits into from
Mar 2, 2023
Merged

minor: Port more window tests to sqlogictests #5434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8d2db0b
Port more window tests to slt
alamb Feb 28, 2023
aa3ef3a
Update tests
alamb Feb 28, 2023
2dbecd3
remove dead code
alamb Feb 28, 2023
debdf41
Fix test to be deterministic
alamb Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions datafusion/core/tests/sql/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1051,23 +1051,6 @@ async fn register_aggregate_simple_csv(ctx: &SessionContext) -> Result<()> {
Ok(())
}

async fn register_aggregate_null_cases_csv(ctx: &SessionContext) -> Result<()> {
// It's not possible to use aggregate_test_100, not enought similar values to test grouping on floats
let schema = Arc::new(Schema::new(vec![
Field::new("c1", DataType::Int64, true),
Field::new("c2", DataType::Float64, true),
Field::new("c3", DataType::Int64, false),
]));

ctx.register_csv(
"null_cases",
"tests/data/null_cases.csv",
CsvReadOptions::new().schema(&schema),
)
.await?;
Ok(())
}

async fn register_aggregate_csv(ctx: &SessionContext) -> Result<()> {
let testdata = datafusion::test_util::arrow_test_data();
let schema = test_util::aggr_test_schema();
Expand Down
Loading