feat: support type coercion for negative operator #5550
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #5423 and #5476
Rationale for this change
After merging the PR #5476 Arrow DataFusion starts to support unsigned integers for bitwise operations.
If we apply "Negative" operator to unsigned integers, we get a negative number. However, type remains unsigned and it throws an error.
That feature solves this problem.
What changes are included in this PR?
Type coercion optimization began to support
Expr::Negativecase.Are these changes tested?
Yes
Are there any user-facing changes?
Yes (they have to correct some mistakes)