-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Minor: clean up aggregates.slt tests #5599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| # ---- | ||
| # [4, 2, 3, 5, 1] | ||
|
|
||
| # TODO: aggregate_timestamps_sum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests are added in #5574
| 110.009 | ||
| 110.009 Decimal128(10, 3) | ||
|
|
||
| # FIX: doesn't check datatype |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added type check per comment
| query RT | ||
| select min(c1), arrow_typeof(min(c1)) from d_table |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
I reviewed this PR carefully. Thanks @alamb |
|
Benchmark runs are scheduled for baseline = 4d07360 and contender = 35a3acf. 35a3acf is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Related to #4495
Rationale for this change
There are some out of date errors I noticed while working on #5574
What changes are included in this PR?
uncomment some tests in aggregates.slt and remove TODOs that have been done
Are these changes tested?
Yes they are tests
Are there any user-facing changes?
No