Skip to content

fix: correct CountWildcardRule and move analyzer into a new directory. #5671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alamb merged 3 commits into from
Mar 21, 2023
Merged

fix: correct CountWildcardRule and move analyzer into a new directory. #5671

alamb merged 3 commits into from
Mar 21, 2023

Conversation

@jackwener
Copy link
Member

@jackwener jackwener commented Mar 21, 2023 •
edited
Loading

Which issue does this PR close?

Closes #.

Rationale for this change

related PR: #5627

What changes are included in this PR?

  • move analyzer to new dir
  • fix CountWildcardRule.

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the optimizer Optimizer rules label Mar 21, 2023
@mingmwang
Copy link
Contributor

mingmwang commented Mar 21, 2023

Should this rule internally call transform_up() or transform_down() ?

@github-actions github-actions bot added the core Core DataFusion crate label Mar 21, 2023
@jackwener jackwener requested a review from alamb March 21, 2023 15:54
@jackwener
Copy link
Member Author

jackwener commented Mar 21, 2023 •
edited
Loading

Should this rule internally call transform_up() or transform_down() ?

Oh, this Rule didn't handle it ...... I will correct it.

@jackwener jackwener changed the title refactor: move analyzer to new dir and polish CountWildcardRule. fix: move analyzer to new dir and polish CountWildcardRule. Mar 21, 2023
@jackwener jackwener changed the title fix: move analyzer to new dir and polish CountWildcardRule. fix: correct CountWildcardRule and move analyzer into a new directory. Mar 21, 2023
alamb
alamb approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @jackwener

datafusion/core/tests/dataframe.rs
.collect()
.await?;

// add `.select(vec![count(Expr::Wildcard)])?` to make sure we can analyze all node instead of just top node.
Copy link
Contributor

@alamb alamb Mar 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb alamb mentioned this pull request Mar 21, 2023
Merged
@alamb alamb merged commit abc14eb into apache:main Mar 21, 2023
@jackwener jackwener deleted the move branch March 22, 2023 01:45
@jiangzhx
Copy link
Contributor

jiangzhx commented Mar 22, 2023 •
edited
Loading

thanks @jackwener for correcting it, I learned a lot from your code.

@jiangzhx jiangzhx mentioned this pull request Mar 22, 2023
Closed
@andygrove andygrove added the bug Something isn't working label Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

@yjshen yjshen yjshen approved these changes

Assignees

No one assigned

Labels

bug Something isn't working core Core DataFusion crate optimizer Optimizer rules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jackwener @mingmwang @jiangzhx @alamb @yjshen @andygrove