Merged
Conversation
github-actions
bot
added
core
This was referenced Mar 30, 2023
alamb
force-pushed
the
alamb/support_interval_type
branch
from
80b25a9 to
06d38fa
Compare
alamb
commented
Mar 30, 2023
| arrow_typeof(interval '5 months'), | ||
| arrow_typeof(interval '5 days 3 nanoseconds') | ||
| ---- | ||
| Interval(YearMonth) Interval(MonthDayNano) |
Contributor
Author
There was a problem hiding this comment.
The fact that this is Interval YearMonth is an artifact -- I think interval .. syntax should always be the same type. I will file a ticket to that effect
tustvold
approved these changes
Mar 30, 2023
|
|
||
|
|
||
| # Create tables with interval values | ||
| # (TODO file ticket) |
Contributor
Author
There was a problem hiding this comment.
Will file a ticket. Thank you for the review
This was referenced Mar 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5651
Rationale for this change
See #5651 (basically I want to be able to interact with intervals like normal). Also related to #5764 from @berkaysynnada
What changes are included in this PR?
INTERVALSQL -->DataType::Interval(MonthDayNano)arrow typeAre these changes tested?
Yes
Are there any user-facing changes?
Yes (you can now do
SELECT '1 day'::interval) and it works!