update count_wildcard_rule for more scenario #6010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiangzhx
force-pushed
the
update_countwildcardrule_more_scenario
branch
2 times, most recently
from
26e18c4 to
4b27111
Compare
alamb
approved these changes
Apr 14, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks good to me -- I especially like the test coverage
Contributor
|
Thank you @jiangzhx |
jiangzhx
force-pushed
the
update_countwildcardrule_more_scenario
branch
from
4b27111 to
86a014f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5473.
add more scenario
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?