fix 592, support alias in window functions #607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jun 23, 2021
| let sql = "SELECT order_id oid, MAX(order_id) OVER () max_oid, MAX(order_id) OVER () max_oid_dup from orders"; | ||
| let expected = "\ | ||
| Projection: #orders.order_id AS oid, #MAX(orders.order_id) AS max_oid, #MAX(orders.order_id) AS max_oid_dup\ | ||
| \n WindowAggr: windowExpr=[[MAX(#orders.order_id)]]\ |
Contributor
There was a problem hiding this comment.
this is pretty cool that the planner has identified the redundancy and only computes MAX once 👍
Member
There was a problem hiding this comment.
not only the planner, the builder also does this for those who use the dataframe apis directly ;)
jimexist
force-pushed
the
fix-592
branch
3 times, most recently
from
ba3b290 to
4d0948b
Compare
houqp
approved these changes
Jun 24, 2021
Contributor
|
Thanks @jimexist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #592
Rationale for this change
turns out there's no need to rebase any
exprs, removing the rebase would resolve the issueWhat changes are included in this PR?
Are there any user-facing changes?