Skip to content

fix: Use arrow bitwise_op as binary_kernels #6093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alamb merged 1 commit into from
Apr 22, 2023
Merged

fix: Use arrow bitwise_op as binary_kernels #6093

alamb merged 1 commit into from
Apr 22, 2023

Conversation

@RTEnzyme
Copy link
Contributor

@RTEnzyme RTEnzyme commented Apr 22, 2023

Which issue does this PR close?

Closes #6066 .

Rationale for this change

What changes are included in this PR?

  • Use arrow::compute::binary as the bitwise_op kernel for array bitwise_op
  • Use arrow::compute::unary as the bitwise_op_scalar kernel.
  • Currying the $METHOD in bitwise_op_scalar function.

Are these changes tested?

Covered by unit tests in binary.rs.

Are there any user-facing changes?

No

@github-actions github-actions bot added the physical-expr Changes to the physical-expr crates label Apr 22, 2023
@RTEnzyme RTEnzyme changed the title fix: Use arrow bitwise_op as binary_kernals fix: Use arrow bitwise_op as binary_kernels Apr 22, 2023
alamb
alamb approved these changes Apr 22, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup @RTEnzyme - thank you

@alamb alamb merged commit f1bae2c into apache:main Apr 22, 2023
@alamb alamb mentioned this pull request Apr 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

physical-expr Changes to the physical-expr crates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use arrow bitwise operation rather than reimplementation

2 participants

@RTEnzyme @alamb