Skip to content

Port test in union.rs to sqllogic #6224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alamb merged 3 commits into from
May 5, 2023
Merged

Port test in union.rs to sqllogic #6224

alamb merged 3 commits into from
May 5, 2023

Conversation

@parkma99
Copy link
Contributor

@parkma99 parkma99 commented May 4, 2023

Which issue does this PR close?

Closes #6215

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels May 4, 2023
jiangzhx
jiangzhx approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@jiangzhx jiangzhx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jiangzhx
jiangzhx reviewed May 4, 2023
View reviewed changes
Copy link
Contributor

@jiangzhx jiangzhx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about use explain

explain 
SELECT c1, c9 FROM aggregate_test_100 
UNION ALL 
SELECT c1, c3 FROM aggregate_test_100 
ORDER BY c9 DESC LIMIT 5

to move all testcase to sqllogictest

@alamb
Copy link
Contributor

alamb commented May 4, 2023

how about use explain

I agree -- we should move all the tests if possible. Thank you @parkma99 and @jiangzhx

@parkma99
Copy link
Contributor Author

parkma99 commented May 5, 2023

Ok，thanks

@jiangzhx
Copy link
Contributor

jiangzhx commented May 5, 2023 •
edited
Loading

Ok，thanks

look good to me.
Thank you for your contribution. 😁

alamb
alamb approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @parkma99 and @jiangzhx for the review!

@alamb alamb merged commit 7d11eaf into apache:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

+1 more reviewer

@jiangzhx jiangzhx jiangzhx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Port tests in union.rs to sqllogictest

3 participants

@parkma99 @alamb @jiangzhx