Improve error message for CREATE EXTERNAL TABLE #6291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
reviewed
May 9, 2023
| } else if self.parser.parse_keywords(&[Keyword::WITH, Keyword::ORDER]) { | ||
| ensure_not_set(&builder.order_exprs, "WITH ORDER")?; | ||
| builder.order_exprs = Some(self.parse_order_by_exprs()?); | ||
| } else if self.parser.parse_keyword(Keyword::WITH) { |
Contributor
There was a problem hiding this comment.
What do you think about using @tz70s 's suggestion at #6257 (comment)
https://docs.rs/sqlparser/0.33.0/sqlparser/parser/struct.Parser.html#method.expect_one_of_keywords
Here is an example of how it could be used: https://github.com/sqlparser-rs/sqlparser-rs/blob/b29b551fa111bbd50c40568f6aea6c49eafc0b9c/src/parser.rs#L6559-L6562
That would also produce an error message that told the user what keywords were expected and what was actually received
Contributor
Author
There was a problem hiding this comment.
OK, I will use it, Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6288
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?