Skip to content

Conversation

@gitccl
Copy link
Contributor

@gitccl gitccl commented May 10, 2023

Which issue does this PR close?

Closes #6303 .

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels May 10, 2023
Copy link
Contributor

@r4ntix r4ntix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks @gitccl

@alamb
Copy link
Contributor

alamb commented May 10, 2023

Thanks @gitccl and @r4ntix for the review 🚀

@alamb alamb merged commit 8a25953 into apache:main May 10, 2023
@gitccl gitccl deleted the sqllogictest branch May 10, 2023 11:24
Ted-Jiang pushed a commit to Ted-Jiang/arrow-datafusion that referenced this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port tests in json.rs to sqllogictest

3 participants