Improve Display for BuiltinScalarFunction #6448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
approved these changes
May 26, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @2010YOUY01 -- this looks great to me
It is consistent with postgres as well 👍
postgres=# select starts_with('foo', 'bar');
starts_with
-------------
f
(1 row)| } | ||
| } | ||
|
|
||
| // Should not be reached |
Contributor
There was a problem hiding this comment.
🤔 Maybe we should put an assert here? I'll do so as a follow on PR
| /// Mapping between SQL function names to `BuiltinScalarFunction` types. | ||
| /// Note that multiple SQL function names can represent the same `BuiltinScalarFunction`. These are treated as aliases. | ||
| /// In case of such aliases, the first SQL function name in the vector is used when displaying the function. | ||
| static ref NAME_TO_FUNCTION: Vec<(&'static str, BuiltinScalarFunction)> = vec
This was referenced May 26, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #6396.
Rationale for this change
Currently
BuiltinScalarFunctionis using the derivedDebugtrait to display function names, it might get slightly different from the actual function names used in the SQL statements.FromStr is used to bind function string in SQL statements to
Enum BuiltinScalarFunctionvariants, it would be better to implementDisplayonBuiltinScalarFunctionas the "reverse" ofFromStrWhat changes are included in this PR?
Are these changes tested?
Added one unit test to make sure
Displayis consistent withFromStrAre there any user-facing changes?
No