reduce search complexity for BuiltinScalarFunction #6479
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,12 +19,16 @@ | |
|
|
||
| use crate::Volatility; | ||
| use datafusion_common::{DataFusionError, Result}; | ||
| use std::collections::HashMap; | ||
| use std::fmt; | ||
| use std::str::FromStr; | ||
| use strum::IntoEnumIterator; | ||
| use strum_macros::EnumIter; | ||
|
|
||
| use lazy_static::lazy_static; | ||
|
|
||
| /// Enum of all built-in scalar functions | ||
| #[derive(Debug, Clone, PartialEq, Eq, Hash, EnumIter, Copy)] | ||
| pub enum BuiltinScalarFunction { | ||
| // math functions | ||
| /// abs | ||
|
|
@@ -204,117 +208,25 @@ pub enum BuiltinScalarFunction { | |
| } | ||
|
|
||
| lazy_static! { | ||
| /// Maps the sql function name to `BuiltinScalarFunction` | ||
| static ref NAME_TO_FUNCTION: HashMap<&'static str, BuiltinScalarFunction> = { | ||
| let mut map: HashMap<&'static str, BuiltinScalarFunction> = HashMap::new(); | ||
| BuiltinScalarFunction::iter().for_each(|func| { | ||
| let a = aliases(&func); | ||
| a.iter().for_each(|a| {map.insert(a, func);}); | ||
| }); | ||
| map | ||
| }; | ||
|
|
||
| /// Maps `BuiltinScalarFunction` --> canonical sql function | ||
| /// First alias in the array is used to display function names | ||
| static ref FUNCTION_TO_NAME: HashMap<BuiltinScalarFunction, &'static str> = { | ||
| let mut map: HashMap<BuiltinScalarFunction, &'static str> = HashMap::new(); | ||
| BuiltinScalarFunction::iter().for_each(|func| { | ||
| map.insert(func, aliases(&func).first().unwrap_or(&"NO_ALIAS")); | ||
| }); | ||
| map | ||
| }; | ||
| } | ||
|
|
||
| impl BuiltinScalarFunction { | ||
|
|
@@ -429,31 +341,130 @@ impl BuiltinScalarFunction { | |
| } | ||
| } | ||
|
|
||
| fn aliases(func: &BuiltinScalarFunction) -> &'static [&'static str] { | ||
|
Contributor
There was a problem hiding this comment. Sorry I commented on the wrong line previously @comphead , should be here. Adding a comment for aliases(): |
||
| match func { | ||
| BuiltinScalarFunction::Abs => &["abs"], | ||
| BuiltinScalarFunction::Acos => &["acos"], | ||
| BuiltinScalarFunction::Acosh => &["acosh"], | ||
| BuiltinScalarFunction::Asin => &["asin"], | ||
| BuiltinScalarFunction::Asinh => &["asinh"], | ||
| BuiltinScalarFunction::Atan => &["atan"], | ||
| BuiltinScalarFunction::Atanh => &["atanh"], | ||
| BuiltinScalarFunction::Atan2 => &["atan2"], | ||
| BuiltinScalarFunction::Cbrt => &["cbrt"], | ||
| BuiltinScalarFunction::Ceil => &["ceil"], | ||
| BuiltinScalarFunction::Cos => &["cos"], | ||
| BuiltinScalarFunction::Cosh => &["cosh"], | ||
| BuiltinScalarFunction::Degrees => &["degrees"], | ||
| BuiltinScalarFunction::Exp => &["exp"], | ||
| BuiltinScalarFunction::Factorial => &["factorial"], | ||
| BuiltinScalarFunction::Floor => &["floor"], | ||
| BuiltinScalarFunction::Gcd => &["gcd"], | ||
| BuiltinScalarFunction::Lcm => &["lcm"], | ||
| BuiltinScalarFunction::Ln => &["ln"], | ||
| BuiltinScalarFunction::Log => &["log"], | ||
| BuiltinScalarFunction::Log10 => &["log10"], | ||
| BuiltinScalarFunction::Log2 => &["log2"], | ||
| BuiltinScalarFunction::Pi => &["pi"], | ||
| BuiltinScalarFunction::Power => &["power", "pow"], | ||
| BuiltinScalarFunction::Radians => &["radians"], | ||
| BuiltinScalarFunction::Random => &["random"], | ||
| BuiltinScalarFunction::Round => &["round"], | ||
| BuiltinScalarFunction::Signum => &["signum"], | ||
| BuiltinScalarFunction::Sin => &["sin"], | ||
| BuiltinScalarFunction::Sinh => &["sinh"], | ||
| BuiltinScalarFunction::Sqrt => &["sqrt"], | ||
| BuiltinScalarFunction::Tan => &["tan"], | ||
| BuiltinScalarFunction::Tanh => &["tanh"], | ||
| BuiltinScalarFunction::Trunc => &["trunc"], | ||
|
|
||
| // conditional functions | ||
| BuiltinScalarFunction::Coalesce => &["coalesce"], | ||
| BuiltinScalarFunction::NullIf => &["nullif"], | ||
|
|
||
| // string functions | ||
| BuiltinScalarFunction::Ascii => &["ascii"], | ||
| BuiltinScalarFunction::BitLength => &["bit_length"], | ||
| BuiltinScalarFunction::Btrim => &["btrim"], | ||
| BuiltinScalarFunction::CharacterLength => { | ||
| &["character_length", "char_length", "length"] | ||
| } | ||
| BuiltinScalarFunction::Concat => &["concat"], | ||
| BuiltinScalarFunction::ConcatWithSeparator => &["concat_ws"], | ||
| BuiltinScalarFunction::Chr => &["chr"], | ||
| BuiltinScalarFunction::InitCap => &["initcap"], | ||
| BuiltinScalarFunction::Left => &["left"], | ||
| BuiltinScalarFunction::Lower => &["lower"], | ||
| BuiltinScalarFunction::Lpad => &["lpad"], | ||
| BuiltinScalarFunction::Ltrim => &["ltrim"], | ||
| BuiltinScalarFunction::OctetLength => &["octet_length"], | ||
| BuiltinScalarFunction::Repeat => &["repeat"], | ||
| BuiltinScalarFunction::Replace => &["replace"], | ||
| BuiltinScalarFunction::Reverse => &["reverse"], | ||
| BuiltinScalarFunction::Right => &["right"], | ||
| BuiltinScalarFunction::Rpad => &["rpad"], | ||
| BuiltinScalarFunction::Rtrim => &["rtrim"], | ||
| BuiltinScalarFunction::SplitPart => &["split_part"], | ||
| BuiltinScalarFunction::StartsWith => &["starts_with"], | ||
| BuiltinScalarFunction::Strpos => &["strpos"], | ||
| BuiltinScalarFunction::Substr => &["substr"], | ||
| BuiltinScalarFunction::ToHex => &["to_hex"], | ||
| BuiltinScalarFunction::Translate => &["translate"], | ||
| BuiltinScalarFunction::Trim => &["trim"], | ||
| BuiltinScalarFunction::Upper => &["upper"], | ||
| BuiltinScalarFunction::Uuid => &["uuid"], | ||
|
|
||
| // regex functions | ||
| BuiltinScalarFunction::RegexpMatch => &["regexp_match"], | ||
| BuiltinScalarFunction::RegexpReplace => &["regexp_replace"], | ||
|
|
||
| // time/date functions | ||
| BuiltinScalarFunction::Now => &["now"], | ||
| BuiltinScalarFunction::CurrentDate => &["current_date"], | ||
| BuiltinScalarFunction::CurrentTime => &["current_time"], | ||
| BuiltinScalarFunction::DateBin => &["date_bin"], | ||
| BuiltinScalarFunction::DateTrunc => &["date_trunc", "datetrunc"], | ||
|
Contributor
There was a problem hiding this comment. I like how this formulation makes it easier to understand what functions have aliases and which do not 👍 |
||
| BuiltinScalarFunction::DatePart => &["date_part", "datepart"], | ||
| BuiltinScalarFunction::ToTimestamp => &["to_timestamp"], | ||
| BuiltinScalarFunction::ToTimestampMillis => &["to_timestamp_millis"], | ||
| BuiltinScalarFunction::ToTimestampMicros => &["to_timestamp_micros"], | ||
| BuiltinScalarFunction::ToTimestampSeconds => &["to_timestamp_seconds"], | ||
| BuiltinScalarFunction::FromUnixtime => &["from_unixtime"], | ||
|
|
||
| // hashing functions | ||
| BuiltinScalarFunction::Digest => &["digest"], | ||
| BuiltinScalarFunction::MD5 => &["md5"], | ||
| BuiltinScalarFunction::SHA224 => &["sha224"], | ||
| BuiltinScalarFunction::SHA256 => &["sha256"], | ||
| BuiltinScalarFunction::SHA384 => &["sha384"], | ||
| BuiltinScalarFunction::SHA512 => &["sha512"], | ||
|
|
||
| // other functions | ||
| BuiltinScalarFunction::Struct => &["struct"], | ||
| BuiltinScalarFunction::ArrowTypeof => &["arrow_typeof"], | ||
|
|
||
| // array functions | ||
| BuiltinScalarFunction::MakeArray => &["make_array"], | ||
| } | ||
| } | ||
|
|
||
| impl fmt::Display for BuiltinScalarFunction { | ||
| fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | ||
| // .unwrap is safe here because compiler makes sure the map will have matches for each BuiltinScalarFunction | ||
| write!(f, "{}", FUNCTION_TO_NAME.get(self).unwrap()) | ||
| } | ||
| } | ||
|
|
||
| impl FromStr for BuiltinScalarFunction { | ||
| type Err = DataFusionError; | ||
| fn from_str(name: &str) -> Result<BuiltinScalarFunction> { | ||
| if let Some(func) = NAME_TO_FUNCTION.get(name) { | ||
| Ok(*func) | ||
| } else { | ||
| Err(DataFusionError::Plan(format!( | ||
| "There is no built-in function named {name}" | ||
| ))) | ||
| } | ||
| } | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// First alias in the array is used to display function namesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is that?