minor: use sql to setup test data for joins.slt rather than rust#6656
Merged
alamb merged 5 commits intoapache:mainfrom Jun 13, 2023
Merged
minor: use sql to setup test data for joins.slt rather than rust#6656alamb merged 5 commits intoapache:mainfrom
alamb merged 5 commits intoapache:mainfrom
Conversation
github-actions
bot
added
core
Contributor
|
Sorry for the late reply. |
aprimadi
approved these changes
Jun 13, 2023
| arrow_cast(c1, 'Date32') as c1, | ||
| arrow_cast(c2, 'Date64') as c2, | ||
| c3, | ||
| arrow_cast(c4, 'Dictionary(Int32, Utf8)') as c4 |
Contributor
There was a problem hiding this comment.
Nice, so that's how to cast a dictionary array.
Contributor
Author
There was a problem hiding this comment.
👍 I think arrow_cast is the key if you want to control the arrow types specifically (otherwise you are stuck with the types that have an SQL mapping)
Contributor
Author
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #6642 from @jiangzhx
related to #6302
Rationale for this change
I noticed we could port more of the rust based setup code in #6642 to use sql which makes it clearer what is going on as well as is more concise
What changes are included in this PR?
Port 4 test setups from Rust to SQL
Are these changes tested?
covered by existing tests
Are there any user-facing changes?
no