Set DisplayAs to be a supertrait of ExecutionPlan
#6835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qrilka
force-pushed
the
execution-plan-as-display-as
branch
from
5e6e5e2 to
8e9a398
Compare
alamb
approved these changes
Jul 5, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @qrilka
While this will generate some non trivial churn in downstream projects that extend ExecutionPlan I think it makes more sense to me
Any thoughts @Dandandan or @mustafasrepo or @jackwener ?
alamb
changed the title
DisplayAs to be a supertrait of ExecutionPlan
This was referenced Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #6711
Which issue does this PR close?
Closes the detail discussed in #6711 (comment)
Rationale for this change
Removes duplication of
fmt_asinExecutionPlanandDisplayAsWhat changes are included in this PR?
Are these changes tested?
As it's a "structural" change no extra tests seem to be needed and existing tests pass.
Are there any user-facing changes?
No