Minor: Add TPCH scale factor 10 to bench.sh, use 10 iteration #6893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
What about increasing the number of iterations as well? This also reduces the variance in the results. |
Dandandan
approved these changes
Jul 9, 2023
Contributor
Author
That is a good idea 🤔 It turns out that DataFusion blew up my machine's memory when trying to run TPCH on SF10 as well. Maybe I also need to limit the memory (so the queries error rather than swap the OS to death) |
alamb
changed the title
Contributor
Author
Changed to 10 in bd6812d |
Contributor
|
Thanks @alamb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #4973
Rationale for this change
The new grouping code is so fast that the measurement noise is becoming significant 😆 so I need larger data
What changes are included in this PR?
add
tpch10as well astpchto bench.shSo you can run
bench.sh run tpch10nowAre these changes tested?
I tested them manually
Are there any user-facing changes?