Skip to content

Minor: Add output to aggregrate_fuzz.rs on failure #6905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
Jul 11, 2023
Merged

Minor: Add output to aggregrate_fuzz.rs on failure #6905

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions datafusion/core/tests/fuzz_cases/aggregate_fuzz.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ use datafusion::physical_plan::aggregates::{
use rand::rngs::StdRng;
use rand::{Rng, SeedableRng};

use datafusion::physical_plan::collect;
use datafusion::physical_plan::memory::MemoryExec;
use datafusion::physical_plan::{collect, displayable, ExecutionPlan};
use datafusion::prelude::{SessionConfig, SessionContext};
use datafusion_physical_expr::expressions::{col, Sum};
use datafusion_physical_expr::{AggregateExpr, PhysicalSortExpr};
Expand Down Expand Up @@ -107,6 +107,10 @@ async fn run_aggregate_test(input1: Vec<RecordBatch>, group_by_columns: Vec<&str
.map(|elem| (col(elem, &schema).unwrap(), elem.to_string()))
.collect::<Vec<_>>();
let group_by = PhysicalGroupBy::new_single(expr);

println!("aggregate_expr: {aggregate_expr:?}");
println!("group_by: {group_by:?}");

let aggregate_exec_running = Arc::new(
AggregateExec::try_new(
AggregateMode::Partial,
Expand All @@ -118,7 +122,7 @@ async fn run_aggregate_test(input1: Vec<RecordBatch>, group_by_columns: Vec<&str
schema.clone(),
)
.unwrap(),
) as _;
) as Arc<dyn ExecutionPlan>;

let aggregate_exec_usual = Arc::new(
AggregateExec::try_new(
Expand All @@ -131,14 +135,14 @@ async fn run_aggregate_test(input1: Vec<RecordBatch>, group_by_columns: Vec<&str
schema.clone(),
)
.unwrap(),
) as _;
) as Arc<dyn ExecutionPlan>;

let task_ctx = ctx.task_ctx();
let collected_usual = collect(aggregate_exec_usual, task_ctx.clone())
let collected_usual = collect(aggregate_exec_usual.clone(), task_ctx.clone())
.await
.unwrap();

let collected_running = collect(aggregate_exec_running, task_ctx.clone())
let collected_running = collect(aggregate_exec_running.clone(), task_ctx.clone())
.await
.unwrap();
assert!(collected_running.len() > 2);
Expand All @@ -162,7 +166,23 @@ async fn run_aggregate_test(input1: Vec<RecordBatch>, group_by_columns: Vec<&str
.zip(&running_formatted_sorted)
.enumerate()
{
assert_eq!((i, usual_line), (i, running_line), "Inconsistent result");
assert_eq!(
(i, usual_line),
(i, running_line),
"Inconsistent result\n\n\
Left Plan:\n{}\n\
Right Plan:\n{}\n\
schema:\n{schema}\n\
Left Ouptut:\n{}\n\
Right Output:\n{}\n\
input:\n{}\n\
",
displayable(aggregate_exec_usual.as_ref()).indent(false),
displayable(aggregate_exec_running.as_ref()).indent(false),
usual_formatted,
running_formatted,
pretty_format_batches(&input1).unwrap(),
);
}
}

Expand Down