Create dfbench, split up tpch benchmark runner into modules
#7054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jul 21, 2023
| use log::info; | ||
| //! tpch binary only entrypoint | ||
| use arrow::util::pretty::pretty_format_batches; |
Contributor
Author
There was a problem hiding this comment.
All this code is moved elsewhere
8 tasks
Contributor
Author
|
cc @Dandandan / @andygrove in case you have time to review this code. I have big plans but this one just moves things around |
Dandandan
approved these changes
Jul 23, 2023
Contributor
|
Looks good to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this looks like a big PR but it just moves code around. I will move the other runners into this new format as follow on PRs
Which issue does this PR close?
Part of #7052
related to #6994
Rationale for this change
I want to have a nice home for clickbench tests #6994 but the current situation in the benchmark runners is a mess
What changes are included in this PR?
dfbenchentrypointtpchbenchmark runner code into moudlesThis PR also retain the old entrypoints for backwards compatibility, so the following two commands do the same thing
Old
New
Are these changes tested?
existing coverage
Are there any user-facing changes?