improve the ergonomics of creating field and list array accesses#7215
Merged
alamb merged 3 commits intoapache:mainfrom Aug 7, 2023
izveigor:refactor_index
Merged
improve the ergonomics of creating field and list array accesses#7215alamb merged 3 commits intoapache:mainfrom izveigor:refactor_index
alamb merged 3 commits intoapache:mainfrom
izveigor:refactor_index
Conversation
github-actions
bot
added
sql
2 tasks
Contributor
Author
|
@alamb @jayzhan211 I wonder if you have free time to review this PR. |
Contributor
|
Thanks @izveigor -- I am checking this one out now |
alamb
approved these changes
Aug 7, 2023
| list_key: Option<Arc<dyn PhysicalExpr>>, | ||
| /// The key expression for `DataType::Struct` | ||
| struct_key: Option<ScalarValue>, | ||
| pub enum GetFieldAccessExpr { |
This was referenced Aug 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7193
Closes #7146
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
Yes