Improve error message for aggregate/window functions #7265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6396 .
Rationale for this change
When wrong function signature is given, it's more clear to provide error message with "what's the right function signature" instead of "what's wrong"
Previous PRs in #6396 have implemented such error messages for built-in scalar functions, this PR would like to also implement it for aggregate/window functions.
Before:
PR:
What changes are included in this PR?
Overwrite original errors for wrong function signature with new one.
Original errors are thrown in
return_type(), I've checked all overwritten errors are for wrong signature, they can be aggregated into one with more detailed error messageAre these changes tested?
sqllogictestsAre there any user-facing changes?
No