Refactor sort_fuzz test to clarify what is covered #7439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Aug 29, 2023
| ) | ||
| .await | ||
| SortTest::new() | ||
| .with_int32_batches(5) |
Contributor
Author
There was a problem hiding this comment.
the idea here is simply to make the test parameters explicit and easier to read
yjshen
approved these changes
Aug 29, 2023
Member
yjshen
left a comment
yjshen
left a comment
There was a problem hiding this comment.
The builder style is much easier to read. Nice refactor!
Contributor
Author
|
Thanks @yjshen ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
related to #7432
Rationale for this change
While working on #7432 I wasn't 100% clear what sort cases were covered, which lead me to
sort_fuzz.I took some time to make that clearer.
What changes are included in this PR?
Rework
sort_fuzzto be a builder styleAre these changes tested?
only tests
Are there any user-facing changes?