[feat] Support columns_sorted in row_filters with pageIndex#7528
Closed
judahrand wants to merge 1 commit intoapache:mainfrom
Closed
[feat] Support columns_sorted in row_filters with pageIndex#7528judahrand wants to merge 1 commit intoapache:mainfrom
judahrand wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
Thanks @judahrand -- I will give this a look |
judahrand
force-pushed
the
columns-sorted
branch
from
fdefa5c to
560e459
Compare
alamb
reviewed
Sep 14, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Is there any way we can make a test for this functionality? Like do we have any parquet files that have is_sorted set?
Contributor
|
Marking as draft as this PR has some feedback that is awaiting addressing |
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3476
I've picked up here where @Ted-Jiang left off in #3477. I think that I've dealt with some of the comments.
However, I'm not sure if we also need to check that the maximum value is each row group is greater than or equal to the value in the previous row group? This would involve accessing the row group level statistics.
I'd really appreciate thoughts and advice here as I'm keen to learn more about Datafusion and hopefully be able to contribute more in the future!
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?