Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Sep 15, 2023

Which issue does this PR close?

Closes #.

Rationale for this change

#7572 makes changes to fix clippy with the newest version of chrono, 0.4.31 but to do so it uses new features from that version of chrono (timestamp_nanos_opt()).

Thus we need to make sure DataFusion declares that it requires at least 0.4.31

What changes are included in this PR?

  1. Change chrono dependency to a workspace dependency and specify at lest 0.4.31

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) substrait Changes to the substrait crate labels Sep 15, 2023
@alamb alamb merged commit e9b3a32 into apache:main Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate optimizer Optimizer rules physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt) substrait Changes to the substrait crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants