Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Oct 1, 2023

Which issue does this PR close?

Closes #7711

Rationale for this change

I would like to make it as easy as possible to use datafusion, which includes good documentation. See #7711 for details

What changes are included in this PR?

See rendered version here: https://github.com/alamb/arrow-datafusion/tree/alamb/doc_intro#readme

Improve the github / crates.io landing page:

  1. Add Rust version information
  2. Add feature flag documentation
  3. misc drive-by doc improvements

Are these changes tested?

N/A

Are there any user-facing changes?

@github-actions github-actions bot added documentation Improvements or additions to documentation core Core DataFusion crate labels Oct 1, 2023
backtrace = ["datafusion-common/backtrace"]
compression = ["xz2", "bzip2", "flate2", "zstd", "async-compression"]
crypto_expressions = ["datafusion-physical-expr/crypto_expressions", "datafusion-optimizer/crypto_expressions"]
default = ["crypto_expressions", "encoding__expressions", "regex_expressions", "unicode_expressions", "compression"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive by fix: I believe the double _ _ is a typo that results in this feature always being on. This makes it so users can disable it if needed

- [x] User Defined `LogicalPlan` nodes
- [x] User Defined `ExecutionPlan` nodes

## Rust Version Compatibility
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to the main landing page

@alamb alamb merged commit b1587c1 into apache:main Oct 3, 2023
@alamb alamb deleted the alamb/doc_intro branch October 3, 2023 10:01
Ted-Jiang pushed a commit to Ted-Jiang/arrow-datafusion that referenced this pull request Oct 7, 2023
* Document crate feature flags

* prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document feature flags

2 participants