Minor: Build concat_internal() with ListArray construction instead of ArrayData #7748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
jayzhan211
changed the title
alamb
approved these changes
Oct 6, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks like an improvement to me -- thank you @jayzhan211
Ted-Jiang
pushed a commit
to Ted-Jiang/arrow-datafusion
that referenced
this pull request
Oct 7, 2023
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Prefer ListArray::new() and array::compute::concat to build Array instead of ArrayData, which I think adds more complexity and difficult for understanding the code. In previous implementation I fails to build it without ArrayData, but now I know how to do :) https://github.com/apache/arrow-datafusion/pull/6879/files#r1261847204
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?