Skip to content

Minor: make tests deterministic #7771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
Oct 9, 2023
Merged

Minor: make tests deterministic #7771

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions datafusion/sqllogictest/test_files/aggregate.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2318,6 +2318,7 @@ CREATE TABLE traces(trace_id varchar, timestamp bigint, other bigint) AS VALUES
(NULL, 0, 0),
('a', NULL, NULL),
('a', 1, 1),
('a', -1, -1),
('b', 0, 0),
('c', 1, 1),
('c', 2, 2),
Expand Down Expand Up @@ -2357,26 +2358,26 @@ NULL 0
query TI
select trace_id, MIN(timestamp) from traces group by trace_id order by MIN(timestamp) asc limit 4;
----
a -1
NULL 0
b 0
c 1
a 1

query TII
select trace_id, other, MIN(timestamp) from traces group by trace_id, other order by MIN(timestamp) asc limit 4;
----
a -1 -1
b 0 0
NULL 0 0
c 1 1
a 1 1

query TII
select trace_id, MIN(other), MIN(timestamp) from traces group by trace_id order by MIN(timestamp), MIN(other) limit 4;
----
a -1 -1
NULL 0 0
b 0 0
c 1 1
a 1 1

statement ok
set datafusion.optimizer.enable_topk_aggregation = true;
Expand Down Expand Up @@ -2468,10 +2469,10 @@ NULL 0
query TI
select trace_id, MIN(timestamp) from traces group by trace_id order by MIN(timestamp) asc limit 4;
----
a -1
NULL 0
b 0
c 1
a 1

query TI
select trace_id, MAX(timestamp) from traces group by trace_id order by MAX(timestamp) desc limit 3;
Expand All @@ -2483,25 +2484,25 @@ a 1
query TI
select trace_id, MIN(timestamp) from traces group by trace_id order by MIN(timestamp) asc limit 3;
----
a -1
NULL 0
b 0
c 1

query TII
select trace_id, other, MIN(timestamp) from traces group by trace_id, other order by MIN(timestamp) asc limit 4;
----
a -1 -1
b 0 0
NULL 0 0
c 1 1
a 1 1

query TII
select trace_id, MIN(other), MIN(timestamp) from traces group by trace_id order by MIN(timestamp), MIN(other) limit 4;
----
a -1 -1
NULL 0 0
b 0 0
c 1 1
a 1 1

#
# regr_*() tests
Expand Down