Minor: include sort expressions in SortPreservingRepartitionExec explain plan
#7796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
alamb
force-pushed
the
alamb/explain_plans
branch
from
d49d32f to
f5210af
Compare
alamb
commented
Oct 11, 2023
| write!( | ||
| f, | ||
| "SortRequiredExec: [{}]", | ||
| PhysicalSortExpr::format_list(&self.expr) |
Contributor
Author
There was a problem hiding this comment.
this is a cleanup to use the same code everywhere to format [PhysicalSortExpr]
| ) | ||
| )?; | ||
|
|
||
| if let Some(sort_exprs) = self.sort_exprs() { |
Contributor
Author
There was a problem hiding this comment.
this is the new behavior
mustafasrepo
approved these changes
Oct 12, 2023
Contributor
mustafasrepo
left a comment
mustafasrepo
left a comment
There was a problem hiding this comment.
Thanks @alamb for this PR. It is LGTM!.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #7794
Rationale for this change
A plan without sort exprs is incorrect, but it was not clear to me this was happening during my initial debugging. I would like to make it easier to debug such errors in the future
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?